Skip to content

Prepare the CLI budget baseline without a linked worktree - #9103

Merged
loopx-agent merged 1 commit into
mainfrom
codex/cli-output-baseline-snapshot-20261120
Nov 20, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/cli-output-baseline-snapshot-20261120

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Goal And Delivered Outcome

The CLI output budget gate materializes its pinned comparison base for two real CLI probes. A full linked checkout can exhaust available disk before the probe starts. Termination at that point can leave a registered worktree.

The gate now uses a private Git index to materialize the CLI source, package sources, scripts, skills and root files at the same pinned commit. Checkout uses the historical attributes. The candidate keeps its existing working tree and staged state. The probe workload and the semantic and output budget assertions continue through the same entry point.

Author Declaration

Written by model_agent (OpenAI Codex, GPT-6).

Implemented against

Criterion Disposition Evidence
Use the exact selected comparison commit even when the upstream ref advances. Implemented The existing ancestry and explicit-base cases exercise the new materialization. A candidate that changes line-ending attributes still reads the historical base bytes.
Avoid registering a baseline worktree. Implemented The active probe sees no linked checkout. A controlled TERM immediately after baseline materialization leaves zero registrations. The old route leaves one in the same controlled test.
Preserve base/head receipt checks and fail clearly if the base CLI is unavailable. Implemented The real probes produce equal 98-row receipts within each comparison. A commit with no CLI package is rejected before running a probe.

Validation

Head facacd83d89df63318f6ee431ca63646a0953286 and base 8e9a28a866da06cc6fd63e78709910fe35dad564 on macOS.

Check kind Result Evidence
real_entrypoint passed The standard CLI output-budget smoke ran both probe arms and reported 98 base rows, 98 candidate rows and zero review signals.
regression_parity passed Both the old and new materialization routes produce equal base/head receipts within their own real comparison.
integration passed 391 focused Python tests passed and 7 skipped. Tests cover the pinned revision, historical attributes, the caller's staged index, missing CLI source and failed-candidate cleanup.
static passed Five direct premerge checks, four selected standard checks, and Ruff on both changed files.
static failed CI-scope Ruff and configured mypy each report one inherited finding in an unchanged file. Existing static-check repair
integration not_run The full local pytest attempt was stopped before the matrix completed. Native Windows and hosted matrix verification remain pending.

The same pinned base materialized 203,839,453 bytes across 8,449 files in the former linked checkout and 39,184,052 bytes across 2,603 files in the new source tree. These are baseline file bytes measured at probe start. The Git index is a separate temporary file. A hard process interruption can leave scratch files for either route.

Frontend / Visual Evidence

UI impact is none.

Type of Change

  • Bug fix
  • Test update

LoopX Area

  • CI and validation

The commit carries DCO sign-off. Independent review is pending.

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, max)

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机 / Motivation

维护 CLI 输出预算的开发者需要在磁盘受限时仍完成同一套 base/head 检查。 旧流程复制基线的完整 linked worktree。复制失败会阻断 CLI 探针,探针中断还可能留下 Git 工作树登记。 候选用私有 Git index 导出固定基线。两次真实 CLI 对照都得到 98 条相同的 base 与 head receipt 记录,review signals 为零。 真实验证在 macOS 完成。Windows 原生与托管矩阵待验证,突然退出后私有临时文件的清理仍取决于退出方式。 预算检查约定

改动思路 / Approach

先解析原 comparison commit,再用私有 Git index 读取指定树。checkout-index 使用历史索引的属性,导出 CLI、packages、scripts、skills 和根文件。旧的 _run_probe 仍分别执行两个实际 CLI 样本,原 comparator 继续核对语义与输出上限。 基线导出 真实探针

具体改动 / Changes

精确 head facacd83d89df63318f6ee431ca63646a0953286,base 8e9a28a866da06cc6fd63e78709910fe35dad564,两个验证文件 +122/−83。同一基线启动前的文件量由 8,449 个约 204 MB 降为 2,603 个约 39 MB。

  • 固定基线和历史属性用例覆盖上游 ref 移动、历史换行规则和候选 staged index。 Git 对照
  • 真实预算断言得到两次各 98 对 98 的一致 receipt。旧 checkout 走到候选探针时有一次失败,另一次明确在 Git 复制时遇到 ENOSPC。单独从旧精确源码执行原 candidate probe,98 项通过。
  • 中断与缺源码还用隔离 Git 仓库实测。相同阶段的隔离 SIGTERM 对照,旧路径留下 1 条工作树登记,候选为 0。无 CLI 源码的提交在探针前获明确错误。 缺源码用例

对主干的风险 / Risks

同模块 203 项通过、1 项跳过。变更 Ruff、5 项直接检查和 4 项选中预合并检查通过。全仓同一 Ruff 命令在 base 和 head 都得到旧 F401。配置 mypy 在两树均通过。两次完整的候选 smoke 验证运行了原来两侧的 CLI 和预算断言。 既有 Ruff 位置

我的整体评价 / Verdict

同意此精确提交。它缩小现有预算检查所需的基线文件树,并移除正常路径对 linked worktree 登记的依赖。真实 CLI 测量和隔离中断读回都与预期一致。

English verdict: APPROVE. The private Git index preserves the pinned real CLI comparison and avoids a linked worktree registration on interruption. The full-checkout baseline reproduced a disk-space failure, while the exact candidate completed both probe arms.

@loopx-agent
loopx-agent merged commit 3e301ab into main Nov 20, 2026
20 of 25 checks passed
@loopx-agent
loopx-agent deleted the codex/cli-output-baseline-snapshot-20261120 branch November 20, 2026 17:18
loopx-agent added a commit that referenced this pull request Nov 21, 2026
* fix(cli): preserve typed runtime diagnostics in Turn failures

Signed-off-by: LoopX Agent <[email protected]>

* feat(steward): support per-endpoint model preferences and Codex-to-Antigravity failover (#9141)

Signed-off-by: LoopX Agent <[email protected]>

* Keep the prepared Chat adapter available to a retry (#9134)

A failed worker start can finish cleanup after a same-turn retry has
selected the adapter. Keep its lifetime tied to the Session and let
failed dispatch release its own worker registration. The regression
asserts one upstream turn and explicit adapter closure with the Session.

Port the fix from 4453e4bdd77486ec14b952f88ca893310b32e26c.

(cherry picked from commit 173e42b4f051b885c3a3389e1cad9c5722f7b7dd)

Signed-off-by: LoopX Agent <[email protected]>

* fix(steward): recover zero-effect monitors and cleared-replan reports (#9143)

Signed-off-by: LoopX Agent <[email protected]>

* fix(steward): admit flexible_primary_available executor transitions in conversation_scope (#9145)

Signed-off-by: LoopX Agent <[email protected]>

* Verify quota gate scope through signed lane references (#9101)

* test(quota): verify scoped gates through complete lane references

Signed-off-by: LoopX Agent <[email protected]>

* Test canonical quota gates in both public response modes

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* Test C1 planning and Host input from the original quota capture (#9102)

* Use recorded quota decisions in the no-Todo settlement regression

Signed-off-by: LoopX Agent <[email protected]>

* Exercise the complete Host prompt from the captured quota source

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* Prepare the CLI budget baseline with a private Git index (#9103)

Signed-off-by: LoopX Agent <[email protected]>

* Exercise C1 Goal delivery and bound replan from the saved source (#9104)

Signed-off-by: LoopX Agent <[email protected]>

* Keep long claim overlap scopes on demand (#9086)

* Link long thin-claim overlap lists to their receipts

Signed-off-by: LoopX Agent <[email protected]>

* Read claim overlap details without copying the lease

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* fix(quota): preserve explicit Monitor Todo selection (#9099)

Carry Todo selection provenance into quota admission. Preserve explicit secondary Monitor polling and recovery from previously admitted receipts.

Signed-off-by: LoopX Agent <[email protected]>

* Keep ready Todo scope details on the required context read (#9106)

Signed-off-by: LoopX Agent <[email protected]>

* Fix archive rollback with custom install directories (#9066)

* refactor(core): defer benchmark implementations during capability discovery

Preserve the benchmark toolkit public exports and static types while keeping execution and experiment implementations out of metadata discovery. Qualify source and installed Core paths, and reconcile the paired minimal/Standard RFC boundary without changing activation or authority defaults.

Signed-off-by: cicolord <[email protected]>

* Defer Yardstick evaluation until an enabled Explore read

Signed-off-by: cicolord <[email protected]>

* Omit empty Todo summary lanes from ordinary Worker context

Signed-off-by: cicolord <[email protected]>

* fix(update): honor configured archive directories during rollback

Signed-off-by: LoopX Agent <[email protected]>

* fix(lark): replay recall guard on current main

Signed-off-by: huangruiteng <[email protected]>

* docs: record the verified LoopX 2.3.0 release baseline

Signed-off-by: LoopX Agent <[email protected]>

* Preserve quota spend source when prepared work is admitted

Signed-off-by: LoopX Agent <[email protected]>

* test(quota): qualify native saved complete-Turn checkpoints

Signed-off-by: LoopX Agent <[email protected]>

* Retry cleanup of an owned file mutation marker

Signed-off-by: LoopX Agent <[email protected]>

* Keep synthetic Git-path test data outside the public source scan

Signed-off-by: LoopX Agent <[email protected]>

* fix(quota): share native preparation wait with readiness

Signed-off-by: LoopX Agent <[email protected]>

* fix(doctor): bind package update readback to its Python environment

Signed-off-by: LoopX Agent <[email protected]>

* Keep Doctor discovery separate from service activation

Signed-off-by: LoopX Agent <[email protected]>

* Verify the recorded Python launcher before Doctor probes it

Signed-off-by: LoopX Agent <[email protected]>

* fix(desktop): require runtime qualification for macOS preview updates

Signed-off-by: LoopX Agent <[email protected]>

* fix(quota): reuse replan projection owners during recovery

Signed-off-by: LoopX Agent <[email protected]>

* Qualify Codex 0.169 native context replay on main

Signed-off-by: LoopX Agent <[email protected]>

* Stop regenerating retired quota view aliases

Signed-off-by: LoopX Agent <[email protected]>

* fix: pin deferred native context reads to the original capture

Signed-off-by: LoopX Agent <[email protected]>

* Keep native capture navigation within small output budgets

Signed-off-by: LoopX Agent <[email protected]>

* Retire legacy heartbeat work prompt generation

Signed-off-by: LoopX Agent <[email protected]>

* Capture C1 composition failures as receipt diagnostics

Signed-off-by: LoopX Agent <[email protected]>

* Recover interrupted native Todo readiness from the original Turn

Signed-off-by: LoopX Agent <[email protected]>

* Revalidate the original lease before publishing resumed native context

Signed-off-by: LoopX Agent <[email protected]>

* Fence native readiness publication with the canonical lease writer

Signed-off-by: LoopX Agent <[email protected]>

* fix(scheduler): keep Codex fallback on the original C1 runtime

Signed-off-by: LoopX Agent <[email protected]>

* fix(scheduler): pin the originating fallback launchers

Signed-off-by: LoopX Agent <[email protected]>

* Retire the duplicate Codex App scheduler projection

Signed-off-by: LoopX Agent <[email protected]>

* Seed the recorded scheduler profile in the elapsed-backoff fixture

Signed-off-by: LoopX Agent <[email protected]>

* Verify canonical cadence on refused and settled Turns

Signed-off-by: LoopX Agent <[email protected]>

* Pin named Core commands in saved scheduler fallbacks

Signed-off-by: LoopX Agent <[email protected]>

* fix(research): preserve saved case addresses when a version cannot open

Signed-off-by: LoopX Agent <[email protected]>

* Preserve citation focus after a saved study refresh

Signed-off-by: LoopX Agent <[email protected]>

* Capture authenticated LoopX receipts for Research attention (#8790)

* feat(research): capture authenticated LoopX attention receipts

Signed-off-by: lusendong.6789 <[email protected]>
Co-authored-by: TRAE CLI <[email protected]>

* fix(research): tighten attention receipt provenance

Signed-off-by: lusendong.6789 <[email protected]>
Co-authored-by: TRAE CLI <[email protected]>

* fix(research): publish attention captures after source validation

Signed-off-by: huangruiteng <[email protected]>

---------

Signed-off-by: lusendong.6789 <[email protected]>
Signed-off-by: huangruiteng <[email protected]>
Co-authored-by: TRAE CLI <[email protected]>
Co-authored-by: huangruiteng <[email protected]>

* Recover the original Session and Turn from a confirmed Chat task

Signed-off-by: huangruiteng <[email protected]>

* perf(lark,native_chat): eliminate redundant full-directory JSON reparsing in steward chat loops (#9041)

* perf(lark,native_chat): avoid full directory reparsing in steward chat loops

- Make LarkOwnerAttention._route iterate capture candidates lazily so matching stops at the newest valid p2p capture.
- Reuse FileChatDiscovery in PrivateIngressObserver._records while preserving strict field validation and fail-closed errors.
- Reuse FileChatDiscovery in ChatExternalConversations.pending so unchanged request journals skip redundant JSON reads and stay mutation-isolated.
- Add regression and scan-efficiency tests in tests/test_lark_steward_directory_scan_perf.py.

Signed-off-by: LoopX Agent <[email protected]>

* fix(native-chat): project small recovery metadata fields to stop data_url memory growth

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* Retire transitional smoke checks and duplicate execution (#9073)

Signed-off-by: lusendong.6789 <[email protected]>
Co-authored-by: TRAE CLI <[email protected]>

* feat(steward): support probe-gated generic continuous_monitor todos with handoff and user actions (#9074)

Signed-off-by: LoopX Agent <[email protected]>

* Remove redundant defensive prose from prompts and comments (#9072)

Remove redundant defensive prose while preserving published heartbeat wrappers and externally managed skill readiness.

Validated with 197 related tests, independent historical wrapper migrations and negative cases, installed-skill readback, and current-main quick canary. Existing CI qualification and infrastructure limitations remain recorded in PR #9072.

Signed-off-by: lusendong.6789 <[email protected]>
Signed-off-by: Lusen Dong <[email protected]>

* Keep original Chat retry errors visible during receipt refresh

Signed-off-by: LoopX Agent <[email protected]>

* fix(steward): tolerate report validator python drift and allow cancel of mid-turn failed reports (#9077)

Signed-off-by: LoopX Agent <[email protected]>

* feat(steward): add exact-head PR review signals and protected merge confirmation (#9081)

Signed-off-by: LoopX Agent <[email protected]>

* feat(steward): add isolated OpenViking long-term memory with per-speaker boundaries (#9083)

Signed-off-by: LoopX Agent <[email protected]>

* refactor(content-ops): slim surface module and eliminate Any (#8961)

* refactor(content-ops): slim surface module and eliminate Any

Signed-off-by: LoopX Agent <[email protected]>

* fix(content-ops): reject malformed angle source_item_ids containers

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* fix(collaboration): batch handoff query Goal lifetime guard lock per Goal (#9085)

Signed-off-by: LoopX Agent <[email protected]>

* fix(hosts): raise managed service startup readiness timeout to 45s (#9087)

Signed-off-by: LoopX Agent <[email protected]>

* perf(manager-context): memoize history_inspect lifecycle checks and scope runtime revision in handoffs query (#9088)

Eliminate the remaining O(N) Effect runtime RPCs and uncached runtime fingerprinting inside tracking.query(): enter effect_runtime_request_scope() for the query, memoize pure history_inspect lifecycle decisions across entries sharing identical Goal refs while holding the Goal lifetime guard, lazily discover legacy ingress files only when external audience recovery needs them, and preserve entry scan order across Goal batches.

Signed-off-by: LoopX Agent <[email protected]>

* refactor(lark): slim private_conversations below 2000 lines with net LOC reduction (#8929)

Signed-off-by: LoopX Agent <[email protected]>

* perf(chat,hosts): skip frontend source re-hashing on immutable installed releases and extend readiness timeout to 90s (#9089)

Signed-off-by: LoopX Agent <[email protected]>

* refactor(control-plane): split and slim quota monitor_poll_commit (#8885)

* refactor(control-plane): split and slim quota monitor_poll_commit

Signed-off-by: LoopX Agent <[email protected]>

* fix(control-plane): preserve legacy lane budget and observation diagnostic order

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* refactor(quota): slim loopx/quota.py and tighten Any count to zero (#8939)

Signed-off-by: LoopX Agent <[email protected]>

* refactor(native-chat): slim external_conversations below 2k lines and retire ceiling (#8911)

* refactor(native-chat): move steward commission mixin to steward_commands and retire external_conversations ceiling

Signed-off-by: LoopX Agent <[email protected]>

* fix(native-chat): respect include_raw_response in retained result recovery

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* refactor(chat): slim chat_runtime below 1,500 lines, fix entry-point project_contexts guard, and retire ceiling (#8920)

* refactor(chat): move session lifecycle mixin to session_open, deduplicate runtime helpers, and retire ceiling

Signed-off-by: LoopX Agent <[email protected]>

* fix(chat): drop turn_done_events slot before waking waiters on Thread.start failure

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* fix(steward): paginate open PR signal GraphQL, allow signal-unavailable monitor recovery, and cache private delivery scans (#9093)

Signed-off-by: LoopX Agent <[email protected]>

* perf(lark,native_chat): back off noop recovery retries and cache recovery lookups (#9096)

Signed-off-by: LoopX Agent <[email protected]>

* perf(native_chat,lark): cache unchanged quota backlog health and interrupt observations (#9098)

Signed-off-by: LoopX Agent <[email protected]>

* perf(lark,native_chat): coalesce listener snapshots and cache recovery event summaries (#9100)

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: cicolord <[email protected]>
Signed-off-by: LoopX Agent <[email protected]>
Signed-off-by: huangruiteng <[email protected]>
Signed-off-by: lusendong.6789 <[email protected]>
Signed-off-by: Lusen Dong <[email protected]>
Co-authored-by: cicolord <[email protected]>
Co-authored-by: huangruiteng <[email protected]>
Co-authored-by: Lusen Dong <[email protected]>
Co-authored-by: TRAE CLI <[email protected]>

* refactor(issue-fix): consolidate maintainer-correction admission and slim pr_lifecycle (#8897)

Signed-off-by: LoopX Agent <[email protected]>

* Fix truncated requests and responses in the Codex API relay (#8713)

* fix(codex relay): fence incomplete model requests before drain

Signed-off-by: LoopX Agent <[email protected]>

* fix(codex relay): surface incomplete upstream responses

Port the verified response framing fix to the request-admission branch. Original candidate 27bc3aee311cdfc6a00466ff9d3b58c7db36e01b.

Signed-off-by: LoopX Agent <[email protected]>

* Bound Codex relay writes to clients that stop reading

Signed-off-by: LoopX Agent <[email protected]>

* Reject upstream chunked responses missing the trailer terminator

Signed-off-by: LoopX Agent <[email protected]>

* Validate upstream chunk data delimiters before relay completion

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* fix(release): repair dsh closeout test, antigravity failover alias, and release download retry (#9147)

Signed-off-by: LoopX Agent <[email protected]>

* docs(release): update v2.4.0 release notes and dsh-loopx-plugin 0.1.1-beta.7 README (#9149)

Signed-off-by: LoopX Agent <[email protected]>

* fix(chat): recover saved answers and diagnose lost workers (#9120)

* fix(chat): recover saved answers and diagnose lost workers

Signed-off-by: LoopX Agent <[email protected]>

* style(lark): keep private_conversations within module line budget

Signed-off-by: LoopX Agent <[email protected]>

* fix(chat): retain execution_worker_exited in pending backlog count

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* fix(chat): resume steward requests lost before dispatch (#9125)

Signed-off-by: LoopX Agent <[email protected]>

* fix(benchmark): restore frozen v1 archives and align checkpoint/runtime tests with C1 defaults (#9151)

Signed-off-by: LoopX Agent <[email protected]>

* fix(release): stabilize CLI help, architecture guards, onboarding gate, and public smokes (#9152)

Signed-off-by: LoopX Agent <[email protected]>

* fix(steward): recover report selection across python upgrades and prevent queue kill on observation monitors (#9155)

Signed-off-by: LoopX Agent <[email protected]>

* fix(release): align extensions, chat, presentation, and transport tests for v2.4.0 (#9156)

Signed-off-by: LoopX Agent <[email protected]>

* fix(control-plane): stabilize v2.4.0 quota, turn-envelope, and capabilities slice (Slice B1) (#9154)

* fix(control-plane): stabilize v2.4.0 quota, turn-envelope, and capabilities slice

Signed-off-by: LoopX Agent <[email protected]>

* fix(quota): preserve tokenless identity and exact numeric types in attach_complete_turn_context

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* fix(steward): recover frozen report contract failures and rebind resumed task leases (#9157)

Signed-off-by: LoopX Agent <[email protected]>

* fix(steward): recover pre-dispatch runtime failures across endpoints and stop receipt-unknown disk churn (#9159)

Signed-off-by: LoopX Agent <[email protected]>

* fix(control_plane): align lease recovery, settlement readback, and runtime fixtures (#9158)

* fix(control_plane): align lease recovery, settlement readback, and runtime fixtures

Signed-off-by: LoopX Agent <[email protected]>

* fix(control_plane): forward record_capture in worker outage test and harden version type guard

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* fix(control-plane): stabilize v2.4.0 explore, context, and checkpoint tail slice (Slice B4) (#9161)

Signed-off-by: LoopX Agent <[email protected]>

* fix(control-plane): stabilize v2.4.0 replan, monitor recovery, and staged-read slice (Slice B5) (#9160)

Signed-off-by: LoopX Agent <[email protected]>

* docs(release): reconcile final v2.4.0 stabilization PRs and boundary wording (#9162)

* docs(release): reconcile final v2.4.0 stabilization PRs and boundary wording

Signed-off-by: LoopX Agent <[email protected]>

* docs(release): align #9158 and #9161 descriptions with verified commits

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>

* fix(steward): tolerate minor JSON delimiter glitches and recover saved report candidates (#9164)

Signed-off-by: LoopX Agent <[email protected]>

* fix(control-plane): preserve bound yardstick reversals in native replan openings (#9165)

Signed-off-by: LoopX Agent <[email protected]>

* fix(native-chat): recover loopback relay 401 failures and isolate test auth (#9167)

Signed-off-by: LoopX Agent <[email protected]>

---------

Signed-off-by: LoopX Agent <[email protected]>
Signed-off-by: cicolord <[email protected]>
Signed-off-by: huangruiteng <[email protected]>
Signed-off-by: lusendong.6789 <[email protected]>
Signed-off-by: Lusen Dong <[email protected]>
Co-authored-by: cicolord <[email protected]>
Co-authored-by: huangruiteng <[email protected]>
Co-authored-by: Lusen Dong <[email protected]>
Co-authored-by: TRAE CLI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant